REF: separate numpy-specific part of can_hold_element #45166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jan 3, 2022
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
would it be better to use None as the return value rathe than using exceptions as control flow ? (e.g. performance)
pandas/core/dtypes/cast.py
Outdated
| return False | ||
|
|
||
|
|
||
| def np_can_hold_element(dtype: np.dtype, element: Any): |
jreback
added
Dtype Conversions
Member
Author
That becomes ambiguous with if the actual element is None. There are some performance concerns i have with this function, but try/except overhead is not among them. |
Contributor
oh ok. |
jreback
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By returning the value instead of just a bool, we open the option to return the casted value, which is what we'll do in the follow-up, which will let us de-duplicate NumericIndex._validate_fill_value. By separating out the np-specific parts, we'll be able to improve perf in a couple of places.