Revert "CI: xfail tests failing on numpy dev" #44452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d779366.
phofl
reviewed
Nov 14, 2021
| @@ -1255,7 +1255,7 @@ def test_to_coo( | |||
| A, rows, cols = ss.sparse.to_coo( | |||
| row_levels=(0, 1), column_levels=(2, 3), sort_labels=sort_labels | |||
| ) | |||
| assert isinstance(A, scipy.sparse.coo_matrix) | |||
| assert isinstance(A, scipy.sparse.coo.coo_matrix) | |||
There was a problem hiding this comment.
This should be kept I think? Same one above?
There was a problem hiding this comment.
Or did they change that back too?
There was a problem hiding this comment.
Yeah agree this should be kept as is
alimcmaster1
approved these changes
Nov 15, 2021
|
@meeseeksdev backport 1.3.x |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
simonjayhawkins
pushed a commit
to simonjayhawkins/pandas
that referenced
this pull request
Nov 15, 2021
simonjayhawkins
added a commit
that referenced
this pull request
Nov 15, 2021
…4469) Co-authored-by: Thomas Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #44362
closes #44343