ENH: expose ujson precise_float argument on decode #4300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I can update the docs about how shall I describe this? |
Contributor
Author
|
Doh, I never think about the docs, ujson describe it as |
Contributor
|
perfect...let's get everything merged in and i'll fix the docs....let me know what to merge and in which order (prob doesn't matter) testing on windows now |
Contributor
|
both PR passed on windows (amd-64) |
Contributor
Author
|
Order shouldn't matter (I think) as they both touched different files. I re-based both onto master before pushing. |
Contributor
Author
|
I'm happy for this to be merged now and if / when people are happy with #4299 that can be merged too. |
Contributor
|
going (only this one until you tell me #4299) ready....in 3...2....1 |
Contributor
Author
|
Cool, thanks |
Contributor
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version of ujson takes a boolean
precise_floatargument when decoding, this should be exposed when decoding pandas objects.