TST: add test on checking objects to concatenate #40822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
lgtm |
jbrockmendel
reviewed
Apr 7, 2021
|
|
||
|
|
||
| def test_concat_no_items_raises(): | ||
| with pytest.raises(ValueError, match="No objects to concatenate"): |
Member
There was a problem hiding this comment.
is there a reference somewhere of discussion on why this should raise rather than return an empty Series/DataFrame?
Contributor
There was a problem hiding this comment.
we don't have any other tests for this?
Contributor
There was a problem hiding this comment.
def test_concat_exclude_none(self):
df = DataFrame(np.random.randn(10, 4))
pieces = [df[:5], None, None, df[5:]]
result = concat(pieces)
tm.assert_frame_equal(result, df)
with pytest.raises(ValueError, match="All objects passed were None"):
concat([None, None])
put near this one
Contributor
Author
There was a problem hiding this comment.
we don't have any other tests for this?
By grepping I did not find that concat is anywhere invoked on an empty list, besides this new test.
$ grep -oPrn 'concat\(\[\]\)' pandas/tests
pandas/tests/reshape/concat/test_concat.py:606:concat([])
Contributor
There was a problem hiding this comment.
can you put it next to the test as i indicated above
jreback
requested changes
Apr 7, 2021
|
|
||
|
|
||
| def test_concat_no_items_raises(): | ||
| with pytest.raises(ValueError, match="No objects to concatenate"): |
Contributor
There was a problem hiding this comment.
we don't have any other tests for this?
jreback
added
Reshaping
Contributor
Author
|
@jreback I moved the test just above |
jreback
approved these changes
Apr 8, 2021
Contributor
|
thanks @ivanovmg |
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking through the enhancement xref #40820,
I noticed that there was no test checking that the ValueError is raised when concatenating an empty sequence.
Added this test.