STY: remove --keep-runtime-typing from pyupgrade Final_Part-5 #40805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fathomer
changed the title
|
@github-actions pre-commit the above hasn't worked - @fathomer could you run pre-commit again please? |
MarcoGorelli
approved these changes
Apr 6, 2021
|
Thanks @fathomer ! |
Thanks @MarcoGorelli for all the help and clear details of the task. |
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
…-dev#40805) * STY: remove --keep-runtime-typing from pyupgrade pandas-dev#40759 Final_Part-5 * fixup pyupgrade * fixup * fixup * noop Co-authored-by: Marco Gorelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix issue #40759 :
Changes here are from PEP585 (e.g. List[str] -> list[str]) and from PEP604 (Optional[str] -> str | None), both of which are only applied in the presence of from future import annotations. Some imports became unused after this so those have been removed.
As there were changes in many files (97) this has been split up into 5 smaller PRs.
This is the final PR 5 of 5.
Checks in this one will pass only when other parts are merged as --keep-runtime-typing is removed the pyupgrade precommit hook.
Refer the discussion here : #40773