Agg functions for df not respecting numeric only with level #40683
Conversation
doc/source/whatsnew/v1.3.0.rst
Outdated
| - Bug in :func:`pandas.util.show_versions` where console JSON output was not proper JSON (:issue:`39701`) | ||
| - Bug in :meth:`DataFrame.convert_dtypes` incorrectly raised ValueError when called on an empty DataFrame (:issue:`40393`) | ||
|
|
||
| - Bug in aggregation functions for :class:`DataFrame` not respecting ``numeric_only`` argument when ``level`` keyword was given (:issue:`40660`) |
There was a problem hiding this comment.
level is really doing a groupby, I think it make senses to move the note there.
There was a problem hiding this comment.
At least, I've always thought about level as being an alias for groupby(level=...).
There was a problem hiding this comment.
yeah, generally try to avoid the 'Other' section.
nb. we have a PR somewhere deprecating level= to these
There was a problem hiding this comment.
Thx, was not sure if groupby was the correct place.
This bug is actually a good argument for the deprecation and removal...
doc/source/whatsnew/v1.3.0.rst
Outdated
| - Bug in :func:`pandas.util.show_versions` where console JSON output was not proper JSON (:issue:`39701`) | ||
| - Bug in :meth:`DataFrame.convert_dtypes` incorrectly raised ValueError when called on an empty DataFrame (:issue:`40393`) | ||
|
|
||
| - Bug in aggregation functions for :class:`DataFrame` not respecting ``numeric_only`` argument when ``level`` keyword was given (:issue:`40660`) |
There was a problem hiding this comment.
yeah, generally try to avoid the 'Other' section.
nb. we have a PR somewhere deprecating level= to these
pandas/tests/groupby/test_groupby.py
Outdated
| tm.assert_series_equal(result, expected) | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("meth", ["max", "min", "sum", "mean", "median"]) |
There was a problem hiding this comment.
hmm can you put these with similar tests, maybe in test_reductions?
|
thanks @phofl |
3 participants
stumbled accross this one