Skip to content

Conversation

@jbrockmendel
Copy link
Member

Much simpler than maybe_promote, which for the most part id like to replace with something like

def maybe_promote(dtype, fill_value):
    inferred, fv = infer_dtype_from(fill_value)
    new_dtype = find_common_type([dtype, inferred])
    return inferred, fv

@jreback jreback added Refactor Internal refactoring of code Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate labels Feb 10, 2021
@jreback jreback added this to the 1.3 milestone Feb 10, 2021
@jreback
Copy link
Contributor

jreback commented Feb 10, 2021

sure can you rebase

@jreback jreback merged commit 38f701e into pandas-dev:master Feb 10, 2021
@jbrockmendel jbrockmendel deleted the ref-ensure_can_hold_na branch February 10, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Refactor Internal refactoring of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants