Fixed comment for pandas.unique #39557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timed pd.unique vs np.unique with 1_000 and 100_000 sequences lengths. In first case np.unique was faster, whereas in the second case pd.unique won. Hence, I propose to make the doc a bit more concrete.
Contributor
|
thanks @Remit |
Member
|
@jreback This was merged directly to 1.2.x and milestoned 1.3 revert on 1.2.x and open PR against master? |
simonjayhawkins
added a commit
that referenced
this pull request
Feb 7, 2021
This reverts commit ee8c1ff.
Contributor
|
oh prob an accident |
simonjayhawkins
pushed a commit
to simonjayhawkins/pandas
that referenced
this pull request
Feb 7, 2021
jreback
pushed a commit
that referenced
this pull request
Feb 7, 2021
Contributor
|
@Remit if you'd like to re-submit this against master. |
Member
jreback
pushed a commit
that referenced
this pull request
Feb 7, 2021
Co-authored-by: Vladimir Podolskiy <[email protected]>
Contributor
|
closed by #39643 |
Contributor
Author
Ok, did so. Thanks! |
CyberQin
pushed a commit
to CyberQin/pandas
that referenced
this pull request
Feb 8, 2021
Co-authored-by: Vladimir Podolskiy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timed pd.unique vs np.unique with 1_000 and 100_000 sequences lengths. In first case np.unique was faster, whereas in the second case pd.unique won.
Hence, I propose to make the doc a bit more accurate.