Skip to content

STYLE Upgrade no-string-hints #39524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 3, 2021
Merged

STYLE Upgrade no-string-hints #39524

merged 3 commits into from
Feb 3, 2021

Conversation

@MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Feb 1, 2021

Precursor to #39501, in which the previous version of no-string-hints was removing the string literals even for Literal["foo"]

@MarcoGorelli MarcoGorelli requested a review from jreback February 1, 2021 10:31
@simonjayhawkins simonjayhawkins added the Code Style Code style, linting, code_checks label Feb 1, 2021
@simonjayhawkins simonjayhawkins added this to the 1.3 milestone Feb 1, 2021
@MarcoGorelli MarcoGorelli mentioned this pull request Feb 3, 2021
Closed
@Dr-Irv Dr-Irv merged commit 1efd74d into pandas-dev:master Feb 3, 2021
@MarcoGorelli MarcoGorelli deleted the upgrade-no-string-hints branch February 3, 2021 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jreback jreback Awaiting requested review from jreback

Assignees

No one assigned

Labels

Code Style Code style, linting, code_checks

Projects

None yet

Milestone

1.3

Development

Successfully merging this pull request may close these issues.

3 participants

@MarcoGorelli @simonjayhawkins @Dr-Irv