BUG: Datetimelike equality comparisons with Categorical #38986
Conversation
jreback
changed the title
jreback
added
Testing
| # with (some) integers, depending on the value. | ||
| pass | ||
|
|
||
| def test_compare_with_Categorical(self): |
There was a problem hiding this comment.
can you parameterize this over the types (date_range and such),
also pls add a case for !=
| # with (some) integers, depending on the value. | ||
| pass | ||
|
|
||
| def test_compare_with_Categorical(self): |
There was a problem hiding this comment.
We shouldn't add additional tests to this file (some other files in this directory have a note about that, just opened a PR to add that to this file as well -> #39003)
@ftrihardjo can you move the test to eg /tests/arrays/test_datetimelike.py ? (not fully sure what is the best place to put those nowadays) There also already seems to be a test_compare_categorical_dtype test in that file, so you can put it close to that one (or see to what extent it overlaps)
| with pytest.raises(ValueError, match="Lengths must match"): | ||
| idx <= idx[[0]] | ||
|
|
||
| def test_compare_with_Categorical(self): |
There was a problem hiding this comment.
can you parameterize over pd.date_range,timedetla_range and period_range
|
Hello @ftrihardjo! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-01-08 01:13:09 UTC |
|
thanks @ftrihardjo |
4 participants
Uh oh!
There was an error while loading. Please reload this page.