Remove Python2 numeric relics #38916
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffModernize the code to Python 3 by removing Python 2 numeric hacks, such as:
a / bof two integers now always returns a float, so no need to convertaand/orbto float (or to use float literals)a // bof two integers returns an integer, use it instead ofint(a / b)math.ceil,math.floor, androundreturn integer, so no need to convert the result to integer1e6is a float, converting it toint(1e6)is slower than10 ** 6(or1_000_000)