REF: make pd._testing a directory #38689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Dec 24, 2020
pandas/_testing/__init__.py
Outdated
| from pandas.io.common import urlopen | ||
| from pandas.io.formats.printing import pprint_thing | ||
|
|
||
| from .asserters import ( # noqa:F401 |
| raise ValueError(f"Unrecognized compression type: {compression}") | ||
|
|
||
| with compress_method(path, mode=mode) as f: | ||
| getattr(f, method)(*args) |
Contributor
There was a problem hiding this comment.
would prob move everything else out as well to another module
Contributor
|
can you merge master and ping on green |
jreback
approved these changes
Dec 28, 2020
Contributor
|
great thanks @jbrockmendel nice having green again! |
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've accumulated some other helpers outside of pd._testing that id like to move there (xref #38688). This is a good time to split the large file.