TYP : DataFrame.(merge, join) core.reshape.merge.(merge, ...) (easy) #38468
Conversation
|
looks good. @simonjayhawkins if you can double check here. |
simonjayhawkins
left a comment
simonjayhawkins
left a comment
There was a problem hiding this comment.
Thanks @arw2019 lgtm
in _join_compat, on is passed onto left_on in core.reshape.merge.
presumably both left_on and right_on can also be typed as Optional[IndexLabel] (in DataFrame.merge, core.reshape.merge and _MergeOperation)
pandas/core/frame.py
Outdated
| left_index: bool = False, | ||
| right_index: bool = False, | ||
| sort: bool = False, | ||
| suffixes: Tuple[str, str] = ("_x", "_y"), |
There was a problem hiding this comment.
FYI. suffixes can currently be list-like but will change in the future. but I think OK to restrict to tuple here.
There was a problem hiding this comment.
Is it worth creating a Suffix alias? (So there's a single place where the behavior can be changed?) I would also change this to List if doing that
There was a problem hiding this comment.
yes, probably worth creating an alias as used in several places.
I don't think we need to include Sequence though (situation maybe different if types were public/not experimental or we were using a stub that had support for multiple pandas versions).
arw2019
changed the title
arw2019
changed the title
|
thanks @arw2019 |
3 participants
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff