Skip to content

Revert "ENH: Improve performance for df.__setitem__ with list-like indexers" #38208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 1, 2020
Merged

Revert "ENH: Improve performance for df.__setitem__ with list-like indexers" #38208

merged 2 commits into from
Dec 1, 2020

Conversation

simonjayhawkins
Copy link
Member

Reverts #38148 xref #37784 (comment)

@simonjayhawkins simonjayhawkins added Indexing Related to indexing on series/frames, not to indexes themselves Performance Memory or execution speed performance labels Dec 1, 2020
@simonjayhawkins
Copy link
Member Author

flaky test on the Travis push ci job
=========================== short test summary info ============================
FAILED pandas/tests/io/test_html.py::TestReadHtml::test_banklist_url_positional_match[bs4]
= 1 failed, 144300 passed, 3144 skipped, 1435 xfailed, 58 warnings in 2953.57s (0:49:13) =

@simonjayhawkins simonjayhawkins merged commit c2018c1 into master Dec 1, 2020
@simonjayhawkins simonjayhawkins deleted the revert-38148-37954 branch December 1, 2020 10:54
@simonjayhawkins simonjayhawkins mentioned this pull request Dec 1, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Indexing Related to indexing on series/frames, not to indexes themselves Performance Memory or execution speed performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@simonjayhawkins