Skip to content

Conversation

Qbiwan
Copy link
Contributor

@Qbiwan Qbiwan commented Nov 30, 2020

  • xref CLN: C408 Unnecessary dict call - rewrite as a literal #38138

  • tests added / passed

  • passes black pandas

  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

  • whatsnew entry
    identify unnecessary dict call - rewrite as a literal
    Rewrites as dictionary literals for the following files:

    pandas/tests/plotting/frame/test_frame_subplots.py

@jreback jreback added the Code Style Code style, linting, code_checks label Nov 30, 2020
@jreback jreback added this to the 1.2 milestone Nov 30, 2020
@jreback jreback merged commit 56b9a80 into pandas-dev:master Nov 30, 2020
@jreback
Copy link
Contributor

jreback commented Nov 30, 2020

thanks, see my comments on your other PR; you can add more changes in a single PR. If we are getting near the end then pls indicate that (as we actually want to turn o nthe flake option).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants