Skip to content

Conversation

twoertwein
Copy link
Member

read_fwf was using compression=None to infer compression (in addition to compression="infer"). This is undocumented but was enforced in a test.

In #37639, I thought this was the expected behavior for all functions. That as wrong, read_csv explicitly states that compression=None does not infer any compression.

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine can you can add a whatsnew entry (bug fix in I/O for 1.2 is fine), ping on green.

@jreback jreback added the IO CSV read_csv, to_csv label Nov 17, 2020
@jreback jreback added this to the 1.2 milestone Nov 17, 2020
@twoertwein
Copy link
Member Author

@jreback green'ish

@jreback jreback merged commit 1319766 into pandas-dev:master Nov 18, 2020
@jreback
Copy link
Contributor

jreback commented Nov 18, 2020

thanks @twoertwein

@twoertwein twoertwein deleted the compression branch November 19, 2020 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO CSV read_csv, to_csv
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants