Skip to content

Conversation

@mohdkashif93
Copy link
Contributor

Updates the script for inconsistent namespace usage. To be merged after all the errors are fixed with the updated script. The script is described here : MarcoGorelli/PyDataGlobal2020-sprint#1 by @MarcoGorelli

@pep8speaks
Copy link

pep8speaks commented Nov 14, 2020

Hello @mohdkashif93! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-11-18 17:28:47 UTC

@jreback jreback added the Code Style Code style, linting, code_checks label Nov 14, 2020
@jreback jreback added this to the 1.2 milestone Nov 14, 2020
@jreback
Copy link
Contributor

jreback commented Nov 14, 2020

we will likely need to merge master to make sure after some other merges (but wait till this is green)

@jreback
Copy link
Contributor

jreback commented Nov 15, 2020

can you merge master and see if you can fixup and remaining issues ( pre-commits are failing). ping on green.

@MarcoGorelli
Copy link
Member

this is pending on #37852 , once that's in I'd expect this to pass

@MarcoGorelli
Copy link
Member

Hi @mohdkashif93 - can you try fetching and merging upstream/master now please and see if this passes? If not, do you want to fix up the remaining files as well?

@jreback
Copy link
Contributor

jreback commented Nov 17, 2020

yep this needs a rebase and merge on green.

@mohdkashif93
Copy link
Contributor Author

Yes @MarcoGorelli , I will rebase and check if there are any pending errors with the script 😄

@jreback
Copy link
Contributor

jreback commented Nov 18, 2020

can you merge master

@MarcoGorelli MarcoGorelli force-pushed the update_check_for_inconsistent_pandas_namespace_script branch from b03f731 to 8435e30 Compare November 18, 2020 17:25
@MarcoGorelli
Copy link
Member

@jreback I merged master and fixed up the few remaining files - good to go?

@jreback jreback merged commit 16c693a into pandas-dev:master Nov 18, 2020
@jreback
Copy link
Contributor

jreback commented Nov 18, 2020

great thanks @mohdkashif93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Style Code style, linting, code_checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants