DOC: SS01 docstrings errors fixed #37845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/_libs/lib.pyx
Outdated
|
|
||
| def is_float(obj: object) -> bool: | ||
| """ | ||
| Return a boolean if this is a float object. |
Member
There was a problem hiding this comment.
I think these are the same as above (Return True)
Contributor
Author
There was a problem hiding this comment.
changing docstrings to
Return True if given object is [type].
Member
|
Does this fix all the SS01 errors? If so, do you want to add this error code to the relevant check in |
Contributor
Author
|
Sure @MarcoGorelli , thanks |
Member
|
I think you accidentally committed path_to_file.zip ? |
Contributor
Author
|
@MarcoGorelli Indeed... Got it removed! |
jorisvandenbossche
changed the title
jorisvandenbossche
approved these changes
Nov 14, 2020
Member
jorisvandenbossche
left a comment
jorisvandenbossche
left a comment
There was a problem hiding this comment.
Looks good, thanks!
Member
|
Thanks @lucasrodes , and congrats on your first PR to pandas! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #27977
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff