Skip to content

Conversation

@erictleung
Copy link
Contributor

Gregorian is a proper noun
(https://en.wikipedia.org/wiki/Proleptic_Gregorian_calendar). Also,
"proleptic" is modifying the compound noun "Gregorian epoch" rather than
"Gregorian" modifying a "proleptic epoch".

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Gregorian is a proper noun
(https://en.wikipedia.org/wiki/Proleptic_Gregorian_calendar). Also,
"proleptic" is modifying the compound noun "Gregorian epoch" rather than
"Gregorian" modifying a "proleptic epoch".
Copy link
Contributor

@arw2019 arw2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mroeschke mroeschke added the Docs label Nov 9, 2020
@mroeschke mroeschke added this to the 1.2 milestone Nov 9, 2020
@mroeschke mroeschke merged commit 3760f47 into pandas-dev:master Nov 9, 2020
@mroeschke
Copy link
Member

Thanks @erictleung

@erictleung erictleung deleted the fix-calendar-name branch November 10, 2020 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants