BUG: GH36928 Allow dict_keys to be used as column names by read_csv #36937

abmyii · 2020-10-07T08:14:21Z

closes BUG: dict_keys cannot be used as pd.read_csv's names parameter #36928
tests added / passed
passes black pandas
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

pandas/_libs/lib.pyx

pandas/tests/io/parser/test_common.py

dsaxton · 2020-10-07T15:36:30Z

Also can you add a v1.1.4 release note?

abmyii · 2020-10-07T16:37:51Z

Also can you add a v1.1.4 release note?

Where do I do that?

dsaxton · 2020-10-07T16:45:45Z

Also can you add a v1.1.4 release note?

Where do I do that?

/doc/source/whatsnew/v1.1.4 in the regressions section

…ion instead of is_list_like

abmyii · 2020-10-07T17:04:09Z

Done. Thank you for your guidance throughout!

… formatting

doc/source/whatsnew/v1.1.4.rst

dsaxton

LGTM, small wording nit

doc/source/whatsnew/v1.1.4.rst

Co-authored-by: Daniel Saxton <[email protected]>

pep8speaks · 2020-10-08T07:10:09Z

Hello @abmyii! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-10-08 21:11:41 UTC

pandas/tests/io/parser/test_common.py

dsaxton · 2020-10-08T18:34:12Z

@abmyii can you merge master again? I think CI failures are possibly due to upstream changes in isort that appear to be fixed now.

abmyii · 2020-10-08T18:40:26Z

@abmyii can you merge master again? I think CI failures are possibly due to upstream changes in isort that appear to be fixed now.

How would I do that? git merge master on the dict_keys_as_csv_names branch locally and then push? I don't want to mess anything more up!

dsaxton · 2020-10-08T18:47:51Z

How would I do that? git merge master on the dict_keys_as_csv_names branch locally and then push? I don't want to mess anything more up!

Locally you can do

git checkout dict_keys_as_csv_names
git fetch upstream
git merge upstream/master

It should merge cleanly.

abmyii · 2020-10-08T18:48:44Z

Done, thanks.

jreback

minor comment. ping on green.

pandas/io/parsers.py

jreback · 2020-10-10T17:45:05Z

thanks @abmyii

simonjayhawkins · 2020-10-12T13:58:59Z

@meeseeksdev backport 1.1.x

lumberbot-app · 2020-10-12T13:59:39Z

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

Checkout backport branch and update it.

$ git checkout 1.1.x
$ git pull

Cherry pick the first parent branch of the this PR on top of the older branch:

$ git cherry-pick -m1 982dae89225531afabbcbe0c52203cfb2408d507

You will likely have some merge/cherry-pick conflict here, fix them and commit:

$ git commit -am 'Backport PR #36937: BUG: GH36928 Allow dict_keys to be used as column names by read_csv'

Push to a named branch :

git push YOURFORK 1.1.x:auto-backport-of-pr-36937-on-1.1.x

Create a PR against branch 1.1.x, I would have named this PR:

"Backport PR #36937 on branch 1.1.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

…_keys to be used as column names by read_csv

…e used as column names by read_csv (#37078) Co-authored-by: abmyii <[email protected]>

…andas-dev#36937)

BUG: GH36928 Allow dict_keys to be used as column names by read_csv

5289000

abmyii force-pushed the dict_keys_as_csv_names branch from a629a9d to 5289000 Compare October 7, 2020 08:16

dsaxton suggested changes Oct 7, 2020

View reviewed changes

pandas/_libs/lib.pyx Outdated Show resolved Hide resolved

pandas/tests/io/parser/test_common.py Outdated Show resolved Hide resolved

dsaxton added this to the 1.1.4 milestone Oct 7, 2020

dsaxton added IO CSV read_csv, to_csv Regression Functionality that used to work in a prior pandas version labels Oct 7, 2020

BUG: GH36928 Add whatsnew entry and move fix to _validate_names funct…

45e10ff

…ion instead of is_list_like

BUG: GH36928 Use two backticks instead of one in RST for correct code…

b2004b8

… formatting

dsaxton reviewed Oct 7, 2020

View reviewed changes

doc/source/whatsnew/v1.1.4.rst Outdated Show resolved Hide resolved

BUG: GH36928 Improve whatsnew description

1871a41

dsaxton approved these changes Oct 7, 2020

View reviewed changes

doc/source/whatsnew/v1.1.4.rst Outdated Show resolved Hide resolved

Update doc/source/whatsnew/v1.1.4.rst

89c9d51

Co-authored-by: Daniel Saxton <[email protected]>

abmyii force-pushed the dict_keys_as_csv_names branch from ae527c7 to 89c9d51 Compare October 8, 2020 07:11

abmyii added 2 commits October 8, 2020 08:13

Merge branch 'master' into dict_keys_as_csv_names

053af66

Update test_common.py

d165049

dsaxton reviewed Oct 8, 2020

View reviewed changes

pandas/tests/io/parser/test_common.py Outdated Show resolved Hide resolved

abmyii added 3 commits October 8, 2020 17:12

Update test_common.py

1c2296c

Update test_common.py

b3f18b7

Update test_common.py

e742741

Merge branch 'master' into dict_keys_as_csv_names

c462968

jreback requested changes Oct 8, 2020

View reviewed changes

pandas/io/parsers.py Outdated Show resolved Hide resolved

abmyii and others added 2 commits October 8, 2020 22:03

Combine conditions

423545c

Merge branch 'master' into dict_keys_as_csv_names

5d60dbf

abmyii requested a review from jreback October 9, 2020 06:37

jreback approved these changes Oct 10, 2020

View reviewed changes

jreback merged commit 982dae8 into pandas-dev:master Oct 10, 2020

lumberbot-app bot added the Still Needs Manual Backport label Oct 12, 2020

simonjayhawkins pushed a commit to simonjayhawkins/pandas that referenced this pull request Oct 12, 2020

Backport PR pandas-dev#36937 on branch 1.1.x: BUG: GH36928 Allow dict…

fe35eab

…_keys to be used as column names by read_csv

simonjayhawkins mentioned this pull request Oct 12, 2020

Backport PR #36937 on branch 1.1.x: BUG: GH36928 Allow dict_keys to be used as column names by read_csv #37078

Merged

simonjayhawkins removed the Still Needs Manual Backport label Oct 12, 2020

simonjayhawkins added a commit that referenced this pull request Oct 12, 2020

Backport PR #36937 on branch 1.1.x: BUG: GH36928 Allow dict_keys to b…

42c2c74

…e used as column names by read_csv (#37078) Co-authored-by: abmyii <[email protected]>

kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020

BUG: GH36928 Allow dict_keys to be used as column names by read_csv (p…

bc19114

…andas-dev#36937)

Uh oh!

BUG: GH36928 Allow dict_keys to be used as column names by read_csv #36937

BUG: GH36928 Allow dict_keys to be used as column names by read_csv #36937

Uh oh!

Conversation

abmyii commented Oct 7, 2020

Uh oh!

Uh oh!

Uh oh!

dsaxton commented Oct 7, 2020

Uh oh!

abmyii commented Oct 7, 2020

Uh oh!

dsaxton commented Oct 7, 2020

Uh oh!

abmyii commented Oct 7, 2020

Uh oh!

Uh oh!

dsaxton left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pep8speaks commented Oct 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comment last updated at 2020-10-08 21:11:41 UTC

Uh oh!

Uh oh!

dsaxton commented Oct 8, 2020

Uh oh!

abmyii commented Oct 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dsaxton commented Oct 8, 2020

Uh oh!

abmyii commented Oct 8, 2020

Uh oh!

jreback left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jreback commented Oct 10, 2020

Uh oh!

simonjayhawkins commented Oct 12, 2020

Uh oh!

lumberbot-app bot commented Oct 12, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pep8speaks commented Oct 8, 2020 •

edited

Loading

abmyii commented Oct 8, 2020 •

edited

Loading