Skip to content

REF: Categorical.fillna match patterns in other methods #36530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 22, 2020
Merged

REF: Categorical.fillna match patterns in other methods #36530

merged 4 commits into from
Sep 22, 2020

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Sep 21, 2020

Also:

  • always return a copy even if there is nothing to fill
  • validate the fill_value even if there is nothing to fill

WillAyd
WillAyd reviewed Sep 21, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am OK with this in the name of consistency. Can you add a whatsnew?

@WillAyd WillAyd added the API - Consistency Internal Consistency of API/Behavior label Sep 21, 2020
@jreback jreback added the Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate label Sep 21, 2020
@jreback
Copy link
Contributor

jreback commented Sep 21, 2020

what is the visible user change here?

@jbrockmendel
Copy link
Member Author

jbrockmendel commented Sep 21, 2020

what is the visible user change here?

A couple of exception messages changed (see changed tests), always returning a copy even if a no-op, always validate fill value even if no-op (see OP, xref #36466)

@jbrockmendel
Copy link
Member Author

jbrockmendel commented Sep 21, 2020

Possibly closes #19705 cc @TomAugspurger

@jreback jreback added this to the 1.2 milestone Sep 21, 2020
@jbrockmendel
Copy link
Member Author

jbrockmendel commented Sep 22, 2020

whatsnew added + green

@jreback jreback added the Categorical Categorical Data Type label Sep 22, 2020
@jreback jreback merged commit 9884525 into pandas-dev:master Sep 22, 2020
@jreback
Copy link
Contributor

jreback commented Sep 22, 2020

nice code deletion!

@jbrockmendel jbrockmendel deleted the ref-cat-fillna branch September 22, 2020 22:23
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@jbrockmendel
REF: Categorical.fillna match patterns in other methods (pandas-dev#3…
42480cf 
…6530)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WillAyd WillAyd WillAyd left review comments

@TomAugspurger TomAugspurger TomAugspurger approved these changes

Assignees

No one assigned

Labels

API - Consistency Internal Consistency of API/Behavior Categorical Categorical Data Type Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate

Projects

None yet

Milestone

1.2

Development

Successfully merging this pull request may close these issues.

4 participants

@jbrockmendel @jreback @WillAyd @TomAugspurger