Skip to content

REF: pass setitem to unbox_scalar to de-duplicate validation #36234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2020
Merged

REF: pass setitem to unbox_scalar to de-duplicate validation #36234

merged 1 commit into from
Sep 9, 2020

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Sep 8, 2020

Also fixes a test that is failing on master because _np_version_under_118 is no longer defined.

@jreback jreback added this to the 1.2 milestone Sep 8, 2020
@jreback jreback added Refactor Internal refactoring of code Indexing Related to indexing on series/frames, not to indexes themselves labels Sep 9, 2020
@jreback
Copy link
Contributor

jreback commented Sep 9, 2020

lgtm ping on green

@jbrockmendel
Copy link
Member Author

jbrockmendel commented Sep 9, 2020

ping

@jreback jreback merged commit b1d3897 into pandas-dev:master Sep 9, 2020
@jbrockmendel jbrockmendel deleted the cln-unbox-check branch September 9, 2020 00:58
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@jbrockmendel
REF: pass setitem to unbox_scalar to de-duplicate validation (pandas-…
ef5a7e2 
…dev#36234)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Indexing Related to indexing on series/frames, not to indexes themselves Refactor Internal refactoring of code

Projects

None yet

Milestone

1.2

Development

Successfully merging this pull request may close these issues.

2 participants

@jbrockmendel @jreback