Skip to content

BUG: frame._item_cache not cleared when Series is altered #36051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Sep 2, 2020
Merged

BUG: frame._item_cache not cleared when Series is altered #36051

merged 30 commits into from
Sep 2, 2020

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Sep 1, 2020

jbrockmendel and others added 28 commits August 20, 2020 21:19
@jbrockmendel
REF: remove unnecesary try/except
4c5eddd
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
c632c9f 
…f-blockwise-3
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
9e64be3 
…f-blockwise-3
@mathurk1 @jbrockmendel
TST: add test for agg on ordered categorical cols (pandas-dev#35630)
42649fb
@tkmz-n @jbrockmendel
TST: resample does not yield empty groups (pandas-dev#10603) (pandas-…
47121dd 
…dev#35799)
@jbrockmendel
revert accidental rebase
1decb3e
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
57c5dd3 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
a358463 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
ffa7ad7 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
e5e98d4 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
408db5a 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
d3493cf 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
75a805a 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
9f61070 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
2d10f6e 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
3e20187 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
e27d07f 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
c52bed4 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
b69d4d7 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
1c5f8fd 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
061c9e2 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
0129a83 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
4d0d8e8 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
715848f 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
01f9c50 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
5f4f7dc 
…ster
@jbrockmendel
Merge branch 'master' of https://github.com/pandas-dev/pandas into ma…
4f1f4e1 
…ster
@jbrockmendel
BUG: frame._item_cache not cleared when Series is altered
e97fc57
@jreback jreback added Bug Indexing Related to indexing on series/frames, not to indexes themselves labels Sep 1, 2020
@jreback jreback added this to the 1.1.2 milestone Sep 1, 2020
@jreback
Copy link
Contributor

jreback commented Sep 1, 2020

lgtm. ok for 1.1.2 i think. any perf implications?

@jbrockmendel
Copy link
Member Author

jbrockmendel commented Sep 1, 2020

any perf implications?

I dont think so. It's just a dict.pop, and any case when its hit is one where we're doing the wrong thing now.

jreback
jreback approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jreback jreback merged commit c41e500 into pandas-dev:master Sep 2, 2020
@jreback
Copy link
Contributor

jreback commented Sep 2, 2020

thanks @jbrockmendel

@simonjayhawkins
Copy link
Member

simonjayhawkins commented Sep 2, 2020

@meeseeksdev backport 1.1.x

@meeseeksmachine meeseeksmachine mentioned this pull request Sep 2, 2020
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Sep 2, 2020
@jbrockmendel @meeseeksmachine
Backport PR pandas-dev#36051: BUG: frame._item_cache not cleared when…
fab9392 
… Series is altered
@jbrockmendel jbrockmendel deleted the bug-33675 branch September 2, 2020 16:55
simonjayhawkins pushed a commit that referenced this pull request Sep 2, 2020
@meeseeksmachine @jbrockmendel
Backport PR #36051: BUG: frame._item_cache not cleared when Series is…
6c2a9d8 
… altered (#36072)

Co-authored-by: jbrockmendel <[email protected]>
@jbrockmendel jbrockmendel mentioned this pull request Sep 4, 2020
Closed
3 tasks
@hjweide hjweide mentioned this pull request Sep 15, 2020
Closed
3 tasks
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@jbrockmendel
BUG: frame._item_cache not cleared when Series is altered (pandas-dev…
c657ef1 
…#36051)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jreback jreback jreback approved these changes

Assignees

No one assigned

Labels

Bug Indexing Related to indexing on series/frames, not to indexes themselves

Projects

None yet

Milestone

1.1.2

Development

Successfully merging this pull request may close these issues.

Inconsistent retrieval of DataFrame columns as Series.

5 participants

@jbrockmendel @jreback @simonjayhawkins @mathurk1 @tkmz-n