Skip to content

CLN: consistent EA._reduce signatures #35308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 16, 2020
Merged

CLN: consistent EA._reduce signatures #35308

merged 2 commits into from
Jul 16, 2020

Conversation

@simonjayhawkins
Copy link
Member

@simonjayhawkins simonjayhawkins commented Jul 16, 2020

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

TomAugspurger
TomAugspurger reviewed Jul 16, 2020
View reviewed changes
@jreback jreback added this to the 1.1 milestone Jul 16, 2020
@jreback jreback added ExtensionArray Extending pandas with custom dtypes or arrays. Typing type annotations, mypy/pyright type checking labels Jul 16, 2020
@jreback jreback merged commit fe1ea14 into pandas-dev:master Jul 16, 2020
@jreback
Copy link
Contributor

jreback commented Jul 16, 2020

thanks @simonjayhawkins

@simonjayhawkins simonjayhawkins deleted the clean-_reduce branch July 17, 2020 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomAugspurger TomAugspurger TomAugspurger left review comments

Assignees

No one assigned

Labels

Clean ExtensionArray Extending pandas with custom dtypes or arrays. Typing type annotations, mypy/pyright type checking

Projects

None yet

Milestone

1.1

Development

Successfully merging this pull request may close these issues.

3 participants

@simonjayhawkins @jreback @TomAugspurger