TST add test for dtype consistency with pd replace #23305 #35234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 11, 2020 16:34
jreback
requested changes
Jul 13, 2020
| expected = pd.DataFrame({"Per": [pd.Period("2020-01")] * 3}) | ||
| tm.assert_frame_equal(expected, result) | ||
|
|
||
| def test_replace_value_category_type(self, input_category_df, expected_category_df): |
Contributor
There was a problem hiding this comment.
i would just inline the source and expected frame as you are only using them inside this test
jreback
requested changes
Jul 16, 2020
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
looks good some comments; ping on green
| ) | ||
|
|
||
| # replace values in input dataframe using a dict | ||
| input_df = input_df.replace({"a": "z", "obj1": "obj9", "cat1": "catX"}) |
| # create expected dataframe | ||
| expected_dict = {"col1": ["z"], "col2": ["obj9"], "col3": ["catX"]} | ||
| # explicitly cast columns as category | ||
| expected_df = pd.DataFrame(data=expected_dict).astype( |
| input_df = input_df.replace("obj1", "obj9") | ||
| input_df = input_df.replace("cat2", "catX") | ||
|
|
||
| tm.assert_frame_equal(input_df, expected_df) |
Contributor
There was a problem hiding this comment.
similar to below
call this result and expected
jreback
approved these changes
Jul 16, 2020
Contributor
|
thanks @mathurk1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff