Skip to content

TST #24444 added tests #34627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 7, 2020
Merged

TST #24444 added tests #34627

merged 2 commits into from
Jun 7, 2020

Conversation

@OlivierLuG
Copy link
Contributor

@OlivierLuG OlivierLuG commented Jun 7, 2020 •
edited
Loading

At last, there are no issues at all. I've made a new PR.

@MarcoGorelli
Copy link
Member

MarcoGorelli commented Jun 7, 2020

Thanks @OlivierLuG

I've made a new PR to update master. Sorry, there iare conflict. I don't know how to handle that.

There's instructions here in the contributing guide

MarcoGorelli
MarcoGorelli suggested changes Jun 7, 2020
View reviewed changes
@OlivierLuG
TST pandas-dev#24444 added tests
8ab569a 
The test was modified according to review
WillAyd
WillAyd approved these changes Jun 7, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WillAyd WillAyd added the Testing pandas testing functions or related to the test suite label Jun 7, 2020
@WillAyd WillAyd added this to the 1.1 milestone Jun 7, 2020
@mroeschke mroeschke merged commit 69cc851 into pandas-dev:master Jun 7, 2020
@mroeschke
Copy link
Member

mroeschke commented Jun 7, 2020

Thanks @OlivierLuG

@OlivierLuG OlivierLuG deleted the TST_24444_2 branch June 7, 2020 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WillAyd WillAyd WillAyd approved these changes

+1 more reviewer

@MarcoGorelli MarcoGorelli MarcoGorelli requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Testing pandas testing functions or related to the test suite

Projects

None yet

Milestone

1.1

Development

Successfully merging this pull request may close these issues.

Imprecision when converting Period to timestamp

4 participants

@OlivierLuG @MarcoGorelli @mroeschke @WillAyd