Skip to content

Conversation

yehoshuadimarsky
Copy link
Contributor

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Hi, I wrote this utility which I use in production almost daily at my job, and it's been super helpful for me personally to fill a gap - slow writes from Pandas to MS SQL. Figured I'd suggest it in the pandas ecosystem if it could be useful to others.

Wasn't sure where to put it, and didn't want to start a new section, so I put it in Out-of-core. It appeared to be sorted alphabetically, so I put it in that order.

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@yehoshuadimarsky
Copy link
Contributor Author

Just made those changes thanks

@jreback jreback added the IO SQL to_sql, read_sql, read_sql_query label Jun 14, 2020
@jreback
Copy link
Contributor

jreback commented Jun 14, 2020

@yehoshuadimarsky can you update to @jorisvandenbossche comments, otherwise lgtm.

@yehoshuadimarsky
Copy link
Contributor Author

@jreback ok just did, thanks

@jreback jreback added this to the 1.1 milestone Jun 14, 2020
@jreback jreback merged commit db7876b into pandas-dev:master Jun 14, 2020
@jreback
Copy link
Contributor

jreback commented Jun 14, 2020

thanks @yehoshuadimarsky

@yehoshuadimarsky yehoshuadimarsky deleted the ecosystem-bcpandas branch June 14, 2020 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs IO SQL to_sql, read_sql, read_sql_query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants