Skip to content

Conversation

@rorcores
Copy link
Contributor

Added documentation for building using pyenv. Discussed this PR with @WillAyd on gitter on May 20.

Also fixed up another line he mentioned (python setup.py build_ext --inplace -j 4
instead of:
python setup.py build_ext --inplace -j 0) for conda/venv/pyenv.

Have rebuilt the docs and ensured they build properly.

@rorcores
Copy link
Contributor Author

Fixed trailing whitespace and re-submitted.

@rorcores rorcores changed the title Added documentation for building using pyenv DOC: Added documentation for building using pyenv May 30, 2020
@dsaxton dsaxton added the Docs label May 30, 2020
@MarcoGorelli
Copy link
Member

Thanks @rorcores

and re-submitted.

For the future, if you add another commit and push it, the pull request will be updated, there's no need to open a new one

@rorcores
Copy link
Contributor Author

Thanks @rorcores

and re-submitted.

For the future, if you add another commit and push it, the pull request will be updated, there's no need to open a new one

Thanks @MarcoGorelli, really good to know.

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WillAyd WillAyd added this to the 1.1 milestone Jun 5, 2020
@WillAyd
Copy link
Member

WillAyd commented Jun 5, 2020

@datapythonista care to look?

@WillAyd WillAyd merged commit 772c540 into pandas-dev:master Jun 7, 2020
@WillAyd
Copy link
Member

WillAyd commented Jun 7, 2020

Thanks @rorcores

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants