Skip to content

BUG: NaT+Period doesnt match Period+NaT #34242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 19, 2020
Merged

BUG: NaT+Period doesnt match Period+NaT #34242

merged 2 commits into from
May 19, 2020

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented May 19, 2020

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Most of the edits in __add__ and __sub__ are just an un-indent to get rid of an unreachable branch, but found this incorrect case along the way.

@jreback jreback added Bug Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Period Period data type labels May 19, 2020
@jreback jreback added this to the 1.1 milestone May 19, 2020
@jreback jreback merged commit 4f4282f into pandas-dev:master May 19, 2020
@jreback
Copy link
Contributor

jreback commented May 19, 2020

thanks, can you add a whatsnew in followon

@jbrockmendel jbrockmendel deleted the cln-libperiod branch June 6, 2020 16:13
@lithomas1 lithomas1 mentioned this pull request Dec 27, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Bug Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Period Period data type

Projects

None yet

Milestone

1.1

Development

Successfully merging this pull request may close these issues.

2 participants

@jbrockmendel @jreback