CLN: spelling fixes in docstrings #34039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
May 7, 2020
mroeschke
reviewed
May 7, 2020
Member
mroeschke
left a comment
mroeschke
left a comment
There was a problem hiding this comment.
Looks like there are some doctest failures with your changes
Contributor
Author
|
Appears that I didn't change that function, and it looks to have passed in all other Azure pipeline builds. Is this a known flaky test? |
Member
yes. |
simonjayhawkins
approved these changes
May 8, 2020
Member
|
Thanks @akosfurton! The failing Travis build was unrelated test failure |
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
May 8, 2020
* spelling fixes * add whatsnew entry * fix doctests * and one more that wasn't caught
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
* spelling fixes * add whatsnew entry * fix doctests * and one more that wasn't caught
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff