BUG: TimedeltaArray+Period, PeriodArray-TimedeltaArray #33883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can you explain what this PR is changing? |
jreback
requested changes
Apr 30, 2020
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
pls add a whatsnew note.
Contributor
|
can you also add an example in the docs (maybe in the timedelta section) |
Member
Author
PeriodIndex - TimedeltaIndex always raises in master, but for some |
jreback
requested changes
May 9, 2020
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
lgtm. can you add a whatsnew note.
| msg = r"Input has different freq=None from PeriodArray\(freq=Q-DEC\)" | ||
| with pytest.raises(IncompatibleFrequency, match=msg): | ||
| msg = r"Cannot add or subtract timedelta64\[ns\] dtype from period\[Q-DEC\]" | ||
| with pytest.raises(TypeError, match=msg): |
Contributor
There was a problem hiding this comment.
doesn't IncompatibleFrequency inherit from ValueError? so this is technically an api change (ok though)
Member
Author
There was a problem hiding this comment.
yes, this is a change. in the whatsnew i called it a bugfix
jreback
approved these changes
May 13, 2020
Contributor
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffmotivated by the FIXME comment in test_timedelta64.py