BUG, TST, DOC: fix core.missing._akima_interpolate will raise AttributeError #33784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TypeError was in __call__ due to using wrong kwarg `der` instead of `nu`.
Previous logic checked for `der` as a list or int. The new logic lets `scipy.interpolate.Akima1DInterpolator` raise a TypeError if `der` is the wrong type. Updated the docstring appropriately
jreback
added
Bug
Missing-data
jreback
requested changes
Apr 25, 2020
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
lgtm. can you add a whatsnew note. put in bug fixes in 1.1 missing section, just say that clarified documentation on interpolate with method =akima the der parmater must be a scalar or None
… into fix_akima_interpolate_bug
Contributor
Author
|
thanks @jreback, how's that look? |
jreback
approved these changes
Apr 26, 2020
Contributor
|
thanks @hkennyv |
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffWasn't sure if this warranted a whatsnew entry since its mostly code cleanup