Skip to content

TYP: construction #33725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 24, 2020
Merged

TYP: construction #33725

merged 6 commits into from
Apr 24, 2020

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Apr 22, 2020

No description provided.

simonjayhawkins
simonjayhawkins reviewed Apr 22, 2020
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jbrockmendel generally lgtm on first pass.

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Apr 23, 2020
@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Apr 23, 2020
simonjayhawkins
simonjayhawkins reviewed Apr 23, 2020
View reviewed changes
simonjayhawkins
simonjayhawkins reviewed Apr 23, 2020
View reviewed changes
simonjayhawkins
simonjayhawkins reviewed Apr 23, 2020
View reviewed changes
simonjayhawkins
simonjayhawkins reviewed Apr 23, 2020
View reviewed changes
simonjayhawkins
simonjayhawkins reviewed Apr 23, 2020
View reviewed changes
simonjayhawkins
simonjayhawkins reviewed Apr 23, 2020
View reviewed changes
simonjayhawkins
simonjayhawkins approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending green

@jorisvandenbossche jorisvandenbossche merged commit 1a82659 into pandas-dev:master Apr 24, 2020
@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Apr 24, 2020

Thanks!

@jbrockmendel jbrockmendel deleted the typ-construction branch April 24, 2020 14:27
rhshadrach pushed a commit to rhshadrach/pandas that referenced this pull request May 10, 2020
@jbrockmendel @rhshadrach
TYP: construction (pandas-dev#33725)
2a95b79
@simonjayhawkins simonjayhawkins mentioned this pull request Jun 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

Assignees

No one assigned

Labels

Typing type annotations, mypy/pyright type checking

Projects

None yet

Milestone

1.1

Development

Successfully merging this pull request may close these issues.

3 participants

@jbrockmendel @jorisvandenbossche @simonjayhawkins