Skip to content

DOC: Improve to_parquet documentation #33709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2020
Merged

DOC: Improve to_parquet documentation #33709

merged 2 commits into from
May 30, 2020

Conversation

@larroy
Copy link
Contributor

@larroy larroy commented Apr 21, 2020

fixes #29476

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry / NA

@alimcmaster1
Copy link
Member

alimcmaster1 commented Apr 21, 2020 •
edited
Loading

Thanks for the PR @larroy

Looks like this doc string actually lives in pandas/core/frame.py so its rendered here: https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.to_parquet.html

Otherwise looks good to me!

alimcmaster1
alimcmaster1 reviewed Apr 21, 2020
View reviewed changes
@larroy larroy force-pushed the to_parquet_doc branch 3 times, most recently from 6eacb75 to ccc9aab Compare April 22, 2020 00:18
dsaxton
dsaxton reviewed Apr 23, 2020
View reviewed changes
@larroy larroy force-pushed the to_parquet_doc branch 2 times, most recently from 8f47559 to 257de3e Compare April 24, 2020 18:12
alimcmaster1
alimcmaster1 reviewed Apr 26, 2020
View reviewed changes
@alimcmaster1
Copy link
Member

alimcmaster1 commented Apr 26, 2020

LGTM - minor comment

alimcmaster1
alimcmaster1 approved these changes Apr 26, 2020
View reviewed changes
Copy link
Member

@alimcmaster1 alimcmaster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM cc @jreback

@larroy larroy force-pushed the to_parquet_doc branch from bc63674 to e975e4f Compare May 1, 2020 20:15
@larroy larroy changed the title Improve to_parquet documentation DOC: Improve to_parquet documentation May 1, 2020
@alimcmaster1 alimcmaster1 added this to the 1.1 milestone May 23, 2020
@alimcmaster1
Copy link
Member

alimcmaster1 commented May 23, 2020

@pandas-dev/pandas-core to review/merge

WillAyd
WillAyd reviewed May 27, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor typo but looks good otherwise. If you can accept suggested edit should be OK to merge

@pep8speaks
Copy link

pep8speaks commented May 28, 2020 •
edited
Loading

Hello @larroy! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-05-28 17:40:39 UTC

@larroy @WillAyd
Update pandas/core/frame.py
332943b 
Co-authored-by: William Ayd <[email protected]>
@alimcmaster1 alimcmaster1 mentioned this pull request May 30, 2020
Closed
@alimcmaster1
Copy link
Member

alimcmaster1 commented May 30, 2020

Cc @WillAyd this looks good to me.

@WillAyd WillAyd merged commit d5e8edc into pandas-dev:master May 30, 2020
@WillAyd
Copy link
Member

WillAyd commented May 30, 2020

Thanks @larroy

@larroy
Copy link
Contributor Author

larroy commented Jun 1, 2020

Thank you all for the review and help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WillAyd WillAyd WillAyd left review comments

@alimcmaster1 alimcmaster1 alimcmaster1 approved these changes

+1 more reviewer

@dsaxton dsaxton dsaxton left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Docs

Projects

None yet

Milestone

1.1

Development

Successfully merging this pull request may close these issues.

Improve fname documentation for to_parquet

5 participants

@larroy @alimcmaster1 @pep8speaks @WillAyd @dsaxton