Skip to content

BUG: to_sql no longer raises an AttributeError when saving an OBB date #33140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2020
Merged

BUG: to_sql no longer raises an AttributeError when saving an OBB date #33140

merged 1 commit into from
Mar 30, 2020

Conversation

@mroeschke
Copy link
Member

@mroeschke mroeschke commented Mar 30, 2020

@mroeschke mroeschke added Bug IO SQL to_sql, read_sql, read_sql_query labels Mar 30, 2020
@mroeschke mroeschke added this to the 1.1 milestone Mar 30, 2020
@WillAyd
Copy link
Member

WillAyd commented Mar 30, 2020

So does this fully close the associated issue? Might be overlooking but I see the OutofBoundsError in the issue which isn't checked for here

@mroeschke
Copy link
Member Author

mroeschke commented Mar 30, 2020 •
edited
Loading

The OutofBoundsError is no longer the issue since I think an Index with object dtype is created to hold the OOB date. The new issue is that the Index with object dtype raises an AttributeError since it doesn't have a tz attribute

@mroeschke mroeschke merged commit 40b82ea into pandas-dev:master Mar 30, 2020
@mroeschke mroeschke deleted the to_sql_obb branch March 30, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees

No one assigned

Labels

Bug IO SQL to_sql, read_sql, read_sql_query

Projects

None yet

Milestone

1.1

Development

Successfully merging this pull request may close these issues.

to_sql Out of bounds nanosecond timestamp

3 participants

@mroeschke @WillAyd @jorisvandenbossche