Skip to content

CLN: Remove unused cdef variables #33122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2020
Merged

CLN: Remove unused cdef variables #33122

merged 1 commit into from
Mar 29, 2020

Conversation

@ShaharNaveh
Copy link
Contributor

@ShaharNaveh ShaharNaveh commented Mar 29, 2020

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@WillAyd WillAyd added the Clean label Mar 29, 2020
WillAyd
WillAyd approved these changes Mar 29, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jbrockmendel
Copy link
Member

jbrockmendel commented Mar 29, 2020

LGTM

@mroeschke mroeschke merged commit 7673357 into pandas-dev:master Mar 29, 2020
@mroeschke
Copy link
Member

mroeschke commented Mar 29, 2020

Thanks @MomIsBestFriend

@mroeschke mroeschke added this to the 1.1 milestone Mar 29, 2020
@ShaharNaveh ShaharNaveh deleted the CLN-unused-vars-_libs-parsers branch March 29, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees

No one assigned

Labels

Clean

Projects

None yet

Milestone

1.1

Development

Successfully merging this pull request may close these issues.

4 participants

@ShaharNaveh @jbrockmendel @mroeschke @WillAyd