Skip to content

Added const where avaible #32893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 23, 2020
Merged

Added const where avaible #32893

merged 7 commits into from
Mar 23, 2020

Conversation

@ShaharNaveh
Copy link
Contributor

@ShaharNaveh ShaharNaveh commented Mar 21, 2020

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jreback jreback added the Performance Memory or execution speed performance label Mar 21, 2020
@jreback jreback added this to the 1.1 milestone Mar 21, 2020
@jreback
Copy link
Contributor

jreback commented Mar 21, 2020

any perf change?

cc @WillAyd @jbrockmendel

jbrockmendel
jbrockmendel reviewed Mar 21, 2020
View reviewed changes
pandas/_libs/tslibs/conversion.pyx Outdated
int64_t[:] deltas, int32_t pos):
cdef inline bint _infer_tsobject_fold(
_TSObject obj,
ndarray[int64_t] trans,
Copy link
Member

@jbrockmendel jbrockmendel Mar 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make this const int64_t[:]?

@jbrockmendel
Copy link
Member

jbrockmendel commented Mar 21, 2020

LGTM

@ShaharNaveh
Copy link
Contributor Author

ShaharNaveh commented Mar 21, 2020

any perf change?

cc @WillAyd @jbrockmendel

Unsure which function to test, which one you would like to see?

jreback
jreback requested changes Mar 21, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asv on time zone functions

@ShaharNaveh
Copy link
Contributor Author

ShaharNaveh commented Mar 21, 2020 •
edited
Loading

@jreback Actually I can't manage to run asv, I hoped you can give me a specific function/method name to %timeit on Posted below (not sure if I did it right)

@ShaharNaveh
Copy link
Contributor Author

ShaharNaveh commented Mar 22, 2020 

[ 75.00%] ··· tslibs.timestamp.TimestampOps.time_tz_convert                                                 ok
[ 75.00%] ··· ============ =============
                   tz                   
              ------------ -------------
                  None        296±4ns   
               US/Eastern    17.8±0.2μs 
                 <UTC>      5.11±0.04μs 
                tzutc()      5.17±0.2μs 
              ============ =============

[ 75.00%] · For pandas commit 4195bfbe <master> (round 2/2):
[ 75.00%] ·· Building for conda-py3.6-Cython-matplotlib-numba-numexpr-numpy-odfpy-openpyxl-pytables-pytest-scipy-sqlalchemy-xlrd-xlsxwriter-xlwt...
[ 75.00%] ·· Benchmarking conda-py3.6-Cython-matplotlib-numba-numexpr-numpy-odfpy-openpyxl-pytables-pytest-scipy-sqlalchemy-xlrd-xlsxwriter-xlwt
[100.00%] ··· tslibs.timestamp.TimestampOps.time_tz_convert                                                 ok
[100.00%] ··· ============ =============
                   tz                   
              ------------ -------------
                  None        309±3ns   
               US/Eastern    17.6±0.4μs 
                 <UTC>      4.90±0.03μs 
                tzutc()      5.11±0.1μs 
              ============ =============


BENCHMARKS NOT SIGNIFICANTLY CHANGED.

@jbrockmendel jbrockmendel merged commit f20331d into pandas-dev:master Mar 23, 2020
@jbrockmendel
Copy link
Member

jbrockmendel commented Mar 23, 2020

Thanks @MomIsBestFriend

@ShaharNaveh ShaharNaveh deleted the const-tslibs branch March 23, 2020 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

@jreback jreback jreback approved these changes

Assignees

No one assigned

Labels

Performance Memory or execution speed performance

Projects

None yet

Milestone

1.1

Development

Successfully merging this pull request may close these issues.

3 participants

@ShaharNaveh @jreback @jbrockmendel