TST: Avoid bare pytest.raises in test_series.py #32879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 10, 2020 21:05
Found a type-o in one of the error messages and corrected it.
� Conflicts: � pandas/tests/dtypes/test_dtypes.py
They got undone due to new commits to pandas.
� Conflicts: � pandas/tests/dtypes/test_dtypes.py
It showed that the message was one of the not so great ones that I had fixed before with direction from jorisvandenbossche.
jreback
requested changes
Mar 21, 2020
Contributor
|
this is a very tiny api change, but ok. |
added 2 commits
March 21, 2020 18:34
…999_disallow_bare_pytest_raises_misc2
jreback
approved these changes
Mar 22, 2020
Contributor
|
thanks |
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref [Good first issue] TST: Disallow bare pytest.raises #30999
tests added / passed
passes
black pandaspasses
git diff upstream/master -u -- "*.py" | flake8 --diffPlease note that this file had an error message that was pretty ugly, so I changed
it to only include the class name as I have done for other tests.