-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
[ENH] Add "fullmatch" matching mode to Series.str [#32806] #32807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add tests of Series.str.fullmatch Fix formatting
WillAyd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR - looks pretty good! Just a few things
jreback
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might need to update text.rst
WillAyd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit on documentation but otherwise lgtm. @jreback
|
I'm currently rerunning CI tests locally after fixing that linter error. Sorry about that; I didn't know that |
|
Can you merge master one more time? Should resolve CI failure |
|
Merged in changes from master; waiting for the next batch of CI results to come back. |
|
Pushed some changes late last night that should address the remaining issues. |
|
thanks @frreiss very nice! |
fullmatchmode #32806black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffThis is my first PR against this project, so apologies if I've missed any steps in the process. I'm assuming that I'm supposed to fill in the checklist above myself.
This pull request adds the
fullmatchregular expression matching mode to the other modes already present under theSeries.strnamespace. For example:The
fullmatchmatching mode restricts matches to those that only match the entire string. Note the differences frommatch:I've also added regression tests and a "what's new" entry.
I have also opened issue #32806 to cover this new feature.