Skip to content

CLN: avoid _internal_get_values in groupby.generic #32427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2020
Merged

CLN: avoid _internal_get_values in groupby.generic #32427

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pandas/core/groupby/generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,7 @@ def nunique(self, dropna: bool = True) -> Series:
"""
ids, _, _ = self.grouper.group_info

val = self.obj._internal_get_values()
val = self.obj._values

codes, _ = algorithms.factorize(val, sort=False)
sorter = np.lexsort((codes, ids))
Expand Down Expand Up @@ -657,7 +657,7 @@ def value_counts(
)

ids, _, _ = self.grouper.group_info
val = self.obj._internal_get_values()
val = self.obj._values

# groupby removes null keys from groupings
mask = ids != -1
Expand Down Expand Up @@ -774,7 +774,7 @@ def count(self) -> Series:
Count of values within each group.
"""
ids, _, ngroups = self.grouper.group_info
val = self.obj._internal_get_values()
val = self.obj._values

mask = (ids != -1) & ~isna(val)
ids = ensure_platform_int(ids)
Expand Down