Skip to content

CLN: remove unreachable branch in Index._union #32405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2020
Merged

CLN: remove unreachable branch in Index._union #32405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions pandas/core/indexes/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
is_categorical,
is_categorical_dtype,
is_datetime64_any_dtype,
is_datetime64tz_dtype,
is_dtype_equal,
is_extension_array_dtype,
is_float,
Expand Down Expand Up @@ -2525,14 +2524,8 @@ def _union(self, other, sort):
return other._get_reconciled_name_object(self)

# TODO(EA): setops-refactor, clean all this up
if is_datetime64tz_dtype(self):
lvals = self._ndarray_values
else:
lvals = self._values
if is_datetime64tz_dtype(other):
rvals = other._ndarray_values
else:
rvals = other._values
lvals = self._values
rvals = other._values

if sort is None and self.is_monotonic and other.is_monotonic:
try:
Expand Down