Fix PR08, RT02, RT03, and SA01 on pandas.Index.fillna #32355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Why was all of those files in c4099b5 was removed? |
Member
|
@RafifEL looks like something went awry with the git workflow here. Can you |
Contributor
Author
Member
|
Sure! From your branch try: git reset --hard 1dbea46
git push -f origin rafif-feature |
Contributor
Author
I'm Sorry, i was trying to see the HTML of the documentation by using "python doc/make.py html". It got an Error, so i delete the reference folder on this branch to see it. |
WillAyd
requested changes
Mar 2, 2020
Member
WillAyd
left a comment
WillAyd
left a comment
There was a problem hiding this comment.
Nice job getting back to a clean state. Just some minor fixups otherwise should be good to go here
pandas/core/indexes/base.py
Outdated
| ------- | ||
| filled : Index | ||
| filled | ||
| Index. |
Member
There was a problem hiding this comment.
Let's remove this line altogether
Co-Authored-By: William Ayd <[email protected]>
WillAyd
approved these changes
Mar 4, 2020
Member
|
Thanks @RafifEL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff