Implement BlockManager.iset #32350
Merged
Implement BlockManager.iset #32350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
added
Indexing
| unfit_count = len(unfit_mgr_locs) | ||
|
|
||
| new_blocks = [] | ||
| new_blocks: List[Block] = [] |
Member
There was a problem hiding this comment.
rather than add the variable annotation, does new_blocks need to be initialized outside the if else? make_block has the correct return type and the extend wouldn't be needed. (but I guess this mypy fixup is orthogonal to this PR)
Member
There was a problem hiding this comment.
I'm not a fan of variable annotations when not required. but not a blocker.
pandas/core/internals/managers.py
Outdated
| def set(self, item: Label, value): | ||
| """ | ||
| Set new item in-place. Does not consolidate. Adds new Block if not | ||
| contained in the current set of items |
Member
There was a problem hiding this comment.
minor nit. can you aim for one-liners for PEP 257compliance
jreback
approved these changes
Mar 3, 2020
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
lgtm. @simonjayhawkins comments & merge on green.
Member
|
Thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preliminary to the PR that fixes
setitem_with_indexer(#22036, #15686)