Skip to content

TST/CLN: Follow-up to #32158 #32290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2020
Merged

TST/CLN: Follow-up to #32158 #32290

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44a77f1
CLN: Follow-up to #32158
simonjayhawkins Feb 24, 2020
b7892fe
Merge remote-tracking branch 'upstream/master' into window-constructor
simonjayhawkins Feb 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions pandas/tests/window/test_window.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,10 @@ def test_constructor(self, which):
c(win_type="boxcar", window=2, min_periods=1, center=False)

# not valid
msg = "|".join(["min_periods must be an integer", "center must be a boolean"])
for w in [2.0, "foo", np.array([2])]:
with pytest.raises(ValueError, match=msg):
with pytest.raises(ValueError, match="min_periods must be an integer"):
c(win_type="boxcar", window=2, min_periods=w)
with pytest.raises(ValueError, match=msg):
with pytest.raises(ValueError, match="center must be a boolean"):
c(win_type="boxcar", window=2, min_periods=1, center=w)

for wt in ["foobar", 1]:
Expand Down