Skip to content

TST: Fixed bare pytest.raises in test_window.py #32158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 23, 2020
Merged

TST: Fixed bare pytest.raises in test_window.py #32158

merged 2 commits into from
Feb 23, 2020

Conversation

@mabroor
Copy link
Contributor

@mabroor mabroor commented Feb 21, 2020

jbrockmendel
jbrockmendel reviewed Feb 21, 2020
View reviewed changes
@ShaharNaveh ShaharNaveh mentioned this pull request Feb 22, 2020
Closed
5 tasks
WillAyd
WillAyd requested changes Feb 23, 2020
View reviewed changes
@mabroor
Copy link
Contributor Author

mabroor commented Feb 23, 2020

I have adjusted the formatting and split the message per loop.

@mabroor mabroor changed the title Fixed bare pytest.raises in test_window.py TST: Fixed bare pytest.raises in test_window.py Feb 23, 2020
@jreback jreback added the Testing pandas testing functions or related to the test suite label Feb 23, 2020
@jreback jreback added this to the 1.1 milestone Feb 23, 2020
@jreback jreback merged commit 7b99f03 into pandas-dev:master Feb 23, 2020
@jreback
Copy link
Contributor

jreback commented Feb 23, 2020

thanks @mabroor

@mabroor mabroor deleted the 30999_fix_bare_pytest_raises_test_window branch February 23, 2020 19:29
simonjayhawkins added a commit to simonjayhawkins/pandas that referenced this pull request Feb 27, 2020
@simonjayhawkins
CLN: Follow-up to pandas-dev#32158
44a77f1
@simonjayhawkins simonjayhawkins mentioned this pull request Feb 27, 2020
Merged
WillAyd pushed a commit that referenced this pull request Feb 27, 2020
@simonjayhawkins
CLN: Follow-up to #32158 (#32290)
cad3f1c
roberthdevries pushed a commit to roberthdevries/pandas that referenced this pull request Mar 2, 2020
@mabroor @roberthdevries
TST: Fixed bare pytest.raises in test_window.py (pandas-dev#32158)
8edb480
roberthdevries pushed a commit to roberthdevries/pandas that referenced this pull request Mar 2, 2020
@simonjayhawkins @roberthdevries
CLN: Follow-up to pandas-dev#32158 (pandas-dev#32290)
4618e4c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WillAyd WillAyd Awaiting requested review from WillAyd

@jbrockmendel jbrockmendel Awaiting requested review from jbrockmendel

Assignees

No one assigned

Labels

Testing pandas testing functions or related to the test suite

Projects

None yet

Milestone

1.1

Development

Successfully merging this pull request may close these issues.

4 participants

@mabroor @jreback @WillAyd @jbrockmendel