CLN: 29547 replace old string formatting 4 #31963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3vts
requested review from
ShaharNaveh,
WillAyd and
simonjayhawkins
and removed request for
WillAyd
99 tasks
simonjayhawkins
approved these changes
Feb 13, 2020
Member
simonjayhawkins
left a comment
simonjayhawkins
left a comment
There was a problem hiding this comment.
Thanks @3vts lgtm. one comment. not blocker.
added 2 commits
February 13, 2020 22:09
Member
|
Thanks @3vts |
roberthdevries
pushed a commit
to roberthdevries/pandas
that referenced
this pull request
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I splitted PR #31844 in batches, this is the fourth
For this PR I ran the command
grep -l -R -e '%s' -e '%d' -e '\.format(' --include=*.{py,pyx} pandas/and checked all the files that were returned for.format(and changed the old string format for the correspondingfstringsto attempt a full clean of, #29547. I may have missed something so is a good idea to double check just in caseblack pandasgit diff upstream/master -u -- "*.py" | flake8 --diff