REF: Remove CategoricalIndex.get_value #31765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tegorical-get_value
…tegorical-get_value
…tegorical-get_value
…tegorical-get_value
…tegorical-get_value
…tegorical-get_value
Member
jorisvandenbossche
left a comment
jorisvandenbossche
left a comment
There was a problem hiding this comment.
Looks good!
In checking this, I noticed that this PR might fix the following bug (the current get_value fails in take with a different error than those catched when being passed a boolean mask):
s = pd.Series(range(5), index=pd.Categorical(['a', 'b', 'c', 'a', 'b']))
s['a']
could you add a test for that?
…tegorical-get_value
Member
Author
Sure. Is there an associated issue? |
gfyoung
added
Clean
Indexing
Contributor
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is no longer needed following #31724.