REF: move convert_scalar out of cython #31672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Feb 5, 2020
pandas/core/internals/blocks.py
Outdated
| return _putmask_preserve(v, n) | ||
|
|
||
|
|
||
| def _convert_scalar_for_putitemlike(scalar, dtype: np.dtype): |
Contributor
There was a problem hiding this comment.
maybe in pandas.core.dtypes.cast ?
Member
Author
There was a problem hiding this comment.
Sure. With convert_scalar out of libindex, we can move validate_numeric_casting to core.dtypes.cast as well (and after #31662 we'll be able to get rid of libindex.get_value_at, plus util.get_value_at and util.validate_indexer!)
Contributor
|
needs a rebase as well |
Contributor
|
ping on green. |
Member
Author
|
ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's nothing about this that particularly benefits from being in cython (I think until recently this was used within index.pyx) and its clearer in python. Plus we get a slightly smaller/faster build.