Skip to content

Replaced .format with f- strings #31660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Feb 5, 2020
Merged

Replaced .format with f- strings #31660

merged 14 commits into from
Feb 5, 2020

Conversation

@leandermaben
Copy link
Contributor

@leandermaben leandermaben commented Feb 4, 2020 •
edited by simonjayhawkins
Loading

xref #29547
for

  • pandas/util/_print_versions.py
  • pandas/tests/tseries/frequencies/test_to_offset.py

jbrockmendel
jbrockmendel reviewed Feb 4, 2020
View reviewed changes
@alimcmaster1
Copy link
Member

alimcmaster1 commented Feb 4, 2020

Please can you use 1 PR and push the commit to the same branch? #31627

Thanks

@alimcmaster1 alimcmaster1 added Clean Code Style Code style, linting, code_checks labels Feb 4, 2020
@leandermaben
Copy link
Contributor Author

leandermaben commented Feb 4, 2020

#31627 is closed now
There is only one PR

@jreback jreback added this to the 1.1 milestone Feb 5, 2020
@jreback jreback merged commit 531a430 into pandas-dev:master Feb 5, 2020
@jreback
Copy link
Contributor

jreback commented Feb 5, 2020

thanks @leandermaben

@leandermaben
Copy link
Contributor Author

leandermaben commented Feb 5, 2020

Thank you so much @jreback

@simonjayhawkins simonjayhawkins mentioned this pull request Feb 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

Assignees

No one assigned

Labels

Clean Code Style Code style, linting, code_checks

Projects

None yet

Milestone

1.1

Development

Successfully merging this pull request may close these issues.

4 participants

@leandermaben @alimcmaster1 @jreback @jbrockmendel