Skip to content

REF: simplify index.pyx #31168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 24, 2020
Merged

REF: simplify index.pyx #31168

merged 4 commits into from
Jan 24, 2020

Conversation

jbrockmendel
Copy link
Member

simplification of is_definitely_invalid_key is made possible by the recent change to make EA non-hashable.

WillAyd
WillAyd approved these changes Jan 21, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WillAyd WillAyd added the Clean label Jan 21, 2020
@WillAyd WillAyd added this to the 1.1 milestone Jan 21, 2020
@jreback jreback merged commit 4da554f into pandas-dev:master Jan 24, 2020
@jreback
Copy link
Contributor

jreback commented Jan 24, 2020

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the ref-libindex2 branch January 24, 2020 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @WillAyd